-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Ast structure for CoalesceExpression
#4788
Open
karan-batavia
wants to merge
2
commits into
joernio:master
Choose a base branch
from
Privado-Inc:csharp/coalesce-ast
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -196,4 +196,34 @@ class CallTests extends CSharpCode2CpgFixture { | |
} | ||
} | ||
|
||
"null-coalescing operator" should { | ||
val cpg = code(""" | ||
|namespace Baz | ||
|{ | ||
| public class Foo | ||
| { | ||
| private readonly IDatabase db; | ||
| | ||
| public async AnyValue GetValue(string x) | ||
| { | ||
| var value = await db.get(x) ?? new AnyValue(); | ||
| return value; | ||
| } | ||
| } | ||
|} | ||
|""".stripMargin).moreCode(""" | ||
|namespace Baz; | ||
| | ||
|public interface IDatabase { | ||
| public AnyValue get(string x) {} | ||
|} | ||
|""".stripMargin) | ||
|
||
"resolve methodFullName" in { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like AST tests here too, please. Specifically to verify the coalescing operator. |
||
inside(cpg.call.name("get").methodFullName.l) { | ||
case x :: Nil => x shouldBe "Baz.IDatabase.get:AnyValue(System.String)" | ||
case _ => fail("Unexpected call node structure") | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add a
<operator>.coalesce
so that we can embed the correct semanticsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not also be a
callNode
or something similar with the operator you suggested above?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreiDreyer Yes, something like
callAst(callNode, leftAst ++ rightAst)