Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kotlin] keepTypeArguments Flag #4544

Merged
merged 2 commits into from
May 7, 2024
Merged

[kotlin] keepTypeArguments Flag #4544

merged 2 commits into from
May 7, 2024

Conversation

DavidBakerEffendi
Copy link
Collaborator

@DavidBakerEffendi DavidBakerEffendi commented May 7, 2024 •
edited
Loading

  • Similar to [javasrc] keepTypeArguments Flag #4502, but for Kotlin.
  • Made TypeRenderer an object for easier global setting of keepTypeArgument
  • Improved null safety of expr.getCalleeExpression under AstForExpressionsCreator.astsForNonCtorCall

Note: This acknowledges that enabling this flag may break type linking, thus it is hidden and disabled by default.

@DavidBakerEffendi
[kotlin] keepTypeArguments Flag
0468177 
* Similar to #4502, but for Kotlin.
* Made `TypeRenderer` an object for easier global setting of `keepTypeArgument`
* Improved null safety of `expr.getCalleeExpression` under `AstForExpressionsCreator.astsForNonCtorCall`

Resolves #4513
@DavidBakerEffendi DavidBakerEffendi added the kotlin Relates to kotlin2cpg label May 7, 2024
@DavidBakerEffendi DavidBakerEffendi self-assigned this May 7, 2024
@DavidBakerEffendi DavidBakerEffendi merged commit b76b2f1 into master May 7, 2024
5 checks passed
@DavidBakerEffendi DavidBakerEffendi deleted the dave/kotlin/type-argument-flag branch May 7, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-leuthaeuser max-leuthaeuser max-leuthaeuser approved these changes

Assignees

@DavidBakerEffendi DavidBakerEffendi

Labels
kotlin Relates to kotlin2cpg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBakerEffendi @max-leuthaeuser