Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c#] Safe Download Dependency Handling & Cleanups #4367

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

DavidBakerEffendi
Copy link
Collaborator

  • Fixed non-exhaustive matching on string interpolation handling
  • Wrapped the package version check in a try-catch
  • Ignore looking to nuget for packages that are internal to a potential c# monolith
  • Fixed test config loading in fixture

Resolves joernio/DotNetAstGen#23
Resolves joernio/DotNetAstGen#24

* Fixed non-exhaustive matching on string interpolation handling
* Wrapped the package version check in a try-catch
* Ignore looking to nuget for packages that are internal to a potential c# monolith
* Fixed test config loading in fixture
@DavidBakerEffendi DavidBakerEffendi self-assigned this Mar 19, 2024
@DavidBakerEffendi DavidBakerEffendi added the c# Relates to csharpsrc2cpg label Mar 19, 2024
@tuxology tuxology merged commit 9001c04 into master Mar 19, 2024
5 checks passed
@DavidBakerEffendi DavidBakerEffendi deleted the dave/c#/defensive-dependency-downloads branch March 20, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c# Relates to csharpsrc2cpg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle projects in .csproj which are not on Nuget Exit gracefully when nuget fails to get package index
2 participants