[Ruby] do-end Blocks (with implicit &Proc and yield handling) #3928 #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
badly-drawn-wizards
commented
Mar 18, 2024
•
badly-drawn-wizards
commented
- Adds yield RubyNode
- Handles yield in RubyNodeCreator
- Generates a ProcParameter with a unique identifier if a yield is used in a method with no block parameter
- Generates a call to the block parameter for yields
badly-drawn-wizards
force-pushed
the
3928-ruby-do-end-blocks-with-and-yield-handling
branch
from
bc8af93 to
f9e6a51
Compare
...cli/frontends/rubysrc2cpg/src/main/scala/io/joern/rubysrc2cpg/datastructures/RubyScope.scala
Outdated
Show resolved
Hide resolved
...ds/rubysrc2cpg/src/test/scala/io/joern/rubysrc2cpg/querying/ProcParameterAndYieldTests.scala
Show resolved
Hide resolved
DavidBakerEffendi
requested changes
Mar 19, 2024
| scope.useProcParam match { | ||
| case Some(param) => | ||
| astForMemberCall( | ||
| MemberCall(SimpleIdentifier()(node.span.spanStart(param)), ".", "call", node.arguments)(node.span) |
There was a problem hiding this comment.
Could we lower this differently? My concern is that this is closer to reflection in how this is executed, and not sure that our call graph could resolve this.
Could this instead be a SimpleCall?
There was a problem hiding this comment.
Also, concerning flows, the yield needs to map to MethodReturn, how is this done in pysrc2cpg/should we add a return here?
There was a problem hiding this comment.
case node: ast.Yield => unhandled(node)
case node: ast.YieldFrom => unhandled(node)it isn't handled there, but they would need to be handled vastly differently anyway.
...nds/rubysrc2cpg/src/main/scala/io/joern/rubysrc2cpg/astcreation/AstForFunctionsCreator.scala
Outdated
Show resolved
Hide resolved
...nds/rubysrc2cpg/src/main/scala/io/joern/rubysrc2cpg/astcreation/AstForFunctionsCreator.scala
Outdated
Show resolved
Hide resolved
...ds/rubysrc2cpg/src/test/scala/io/joern/rubysrc2cpg/querying/ProcParameterAndYieldTests.scala
Outdated
Show resolved
Hide resolved
DavidBakerEffendi
approved these changes
Mar 19, 2024
DavidBakerEffendi
deleted the
3928-ruby-do-end-blocks-with-and-yield-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.