[jssrc2cpg] Fixed crash on Windows #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`filename` may already be an absolute path on Windows systems when running jssrc2cpg with an absolute path as input directory because node.js Babel works differently there (keeping that absolute path). When calling `in / filename` we would crash on Windows because concatenating two absolute paths with better.files throws an exception then.
DavidBakerEffendi
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filenamemay already be an absolute path on Windows systems when running jssrc2cpg with an absolute path as input directory because node.js Babel works differently there (keeping that absolute path). When callingin / filenamewe would crash on Windows because concatenating two absolute paths with better.files throws an exception then.