[ruby] Begin, Rescue, Ensure (Try-Catch Statements) for intermediate ast #3927 #3970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related issue assumes the RubyNode intermediate AST is complete for Begin, Rescue, Ensure, but this is not the case. The scope of this issue has crept to include handling the ANTLR-to-RubyNode AST feature for these expressions, as well as the AstCreator CPG building. This appears to be the case for a few of the other Ruby issues, which will influence their ETA accordingly.
Additionally, Rescue clauses in Ruby can contain splats which isn't handled yet in parsing. For now the exception list is will be an unknown block and posted as a medium-priority issue. I am unsure if adding a RubyNode for multipleRightHandSide affects anything else.
The scope of this PR is reduced to just the intermediate AST and the AST creator changes will be in a follow up.