[gosrc2cpg] - Global variable as member nodes of package level TypeDecl #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBakerEffendi
requested changes
Oct 24, 2023
There was a problem hiding this comment.
One thing I noticed when trying to bring Python to a similar design, was that the data-flow engine sees field accesses differently when looking at the DDG.
While GoLang is different, and does not have expressions on a module-level necessarily, it may be good to look at the PR to see how I dealt with this pattern: #3750
joern-cli/frontends/gosrc2cpg/src/main/scala/io/joern/gosrc2cpg/astcreation/AstCreator.scala
Outdated
Show resolved
Hide resolved
...rontends/gosrc2cpg/src/main/scala/io/joern/gosrc2cpg/astcreation/AstForTypeDeclCreator.scala
Outdated
Show resolved
Hide resolved
...frontends/gosrc2cpg/src/test/scala/io/joern/go2cpg/passes/ast/VariableReferencingTests.scala
Show resolved
Hide resolved
...ds/gosrc2cpg/src/main/scala/io/joern/gosrc2cpg/astcreation/AstForGenDeclarationCreator.scala
Show resolved
Hide resolved
DavidBakerEffendi
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR to the PR #3734 to model global variables as member nodes of Package level TypeDecl, and its access is converted to
field accesscall.