-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php2cpg] Resolve static method call name when called by self #3736
Conversation
|
||
case Some(expr) => | ||
// composeMethodFullName(name, call.isStatic) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to leave in commented-out code, then please supply a note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, and thanks for the catch - this comment has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will approve once commented-out code is addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since this seems sound to me
When a static method call is made by referring to
self
, the AST node created for it failed to resolve the proper method full name.For example:
The method full name of the call node for
self::bar($x)
isself::bar
, but it should beFoo::bar
.This PR resolves the method full name of functions called by
self
.