[rubysrc2cpg] Fixed Bug with Higher-Order Functions #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When chained calls are made, there may be a higher order function spawned from some sort of do-block. As these do-blocks now also give the method and type in the AST, these needed to be separated as to not become arguments to a call. This PR fixes this case by extracting these from a call's arguments and placing them before a call node in the sequence of AST nodes. May fix #3693
xavierpinho
approved these changes
Oct 2, 2023
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 4, 2023
DavidBakerEffendi
added a commit
that referenced
this pull request
Oct 4, 2023
khemrajrathore
added a commit
to Privado-Inc/joern
that referenced
this pull request
Oct 10, 2023
…oernio#3714)" This reverts commit 662bd23.
khemrajrathore
added a commit
to Privado-Inc/joern
that referenced
this pull request
Oct 10, 2023
…oernio#3714)" This reverts commit 662bd23.
DavidBakerEffendi
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Revert "[rubysrc2cpg] Do-Block Function as Conditional (#3729)" This reverts commit c726bb5. * Revert "[rubysrc2cpg] Chained Higher Order Methods (#3727)" This reverts commit 39dd417. * Revert "[rubysrc2cpg] Fixed Duplicate Do-Blocks Due to Side-Effect (#3720)" This reverts commit 3f0e745. * Revert "[rubysrc2cpg] Comprehensive follow up to #3708's fix (#3714)" This reverts commit 662bd23. * Revert "[rubysrc2cpg] Fixed Bug with Higher-Order Functions (#3708)" This reverts commit 3e9ea97. * Revert "[rubysrc2cpg] General Do-Block Function Fixes (#3676)" This reverts commit 4ef5cdc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chained calls are made, there may be a higher order function spawned from some sort of do-block. As these do-blocks now also give the method and type in the AST, these needed to be separated as to not become arguments to a call.
This PR fixes this case by extracting these from a call's arguments and placing them before a call node in the sequence of AST nodes.
May fix #3693