Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gosrc2cpg] - Go array index access call node handling #3674

Merged
merged 9 commits into from
Sep 19, 2023
Merged

[gosrc2cpg] - Go array index access call node handling #3674

merged 9 commits into from
Sep 19, 2023

Conversation

pandurangpatil
Copy link
Contributor

@pandurangpatil pandurangpatil commented Sep 19, 2023 •
edited
Loading

  1. Refactored the existing implementation of the array IndexAccess call node.
  2. Changed it to handle it recursively, creating those many index access call nodes.
  3. Updated unit tests to cover more use cases.
  4. Ignored IndexAccess unit tests for Map, as it will take more time to handle that scenario. It will be done in a separate PR.
  5. Added file details in warning logs.
  6. Review comment fixes from the PR [gosrc2cpg] - Error handling for cache builder #3666
  7. This PR should resolve [GO] - Error while creating receiver node #3667, [GO] - AccessPathHandling$: Invalid AST: Found member access without second argument. Member access CODE: response.Results[0].Geometry #3648 and [GO] - Handle IndexExpr AST Node #3632

TODO: Handle indexAccess call node for Map type.

ankit-privado and others added 7 commits September 18, 2023 08:47
@ankit-privado
array access ast handling
7a73cca
@ankit-privado
Map access fix
384f281
@pandurangpatil
Merge branch 'master' into go-array-access
89f2022 
joern-cli/frontends/gosrc2cpg/src/main/scala/io/joern/gosrc2cpg/astcreation/AstForPrimitivesCreator.scala
@pandurangpatil
file details in the warning log
04e7c10
@pandurangpatil
Review comment fixes from the PR joernio#3666
f392756 
Review comment fixes from the PR joernio#3666
@pandurangpatil
Index access call node correction and refactor
917d84a 
1. Refactored the existing implementation of array IndexAccess call
node.
2. Changed it to handle it recursively creating those many index access
call nodes.
3. Updated unit tests to cover more use cases.
4. Ignored IndexAccess unit tests for Map, as it will take more time to
handle that scenario. Will be done in separate PR.

TODO: Handle indexAccess call node for `Map` type.
@pandurangpatil
Merge branch 'master' into go-array-access
69de169
@DavidBakerEffendi DavidBakerEffendi merged commit 89ab1bf into joernio:master Sep 19, 2023
@pandurangpatil pandurangpatil deleted the go-array-access branch September 19, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBakerEffendi DavidBakerEffendi DavidBakerEffendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GO] - Error while creating receiver node
3 participants
@pandurangpatil @DavidBakerEffendi @ankit-privado