add functionality to clone graphs (important for unit test performance)

[bbrehm]

I think you needed that for unit test performance in joern + codescience.

[bbrehm]

@mpollmeier if you want to do changes to this yourself, feel free to push on the branch and merge.

If you want me to do the changes, then add a note here and I will do (e.g. make storagepath val again, or factor out the code into a helper object).

You can also hit the merge button and change this later.

Please let me now whether this solves the unit-test performance problem!

[mpollmeier]

my changes are rather large so I'll create a follow-up PR.

[mpollmeier]

This is actually incomplete - I added a test that fails. The root cause is that cloneThing does not really clone anything besides Array[GNode] - for everything else it just returns the identity. For all primitive arrays and known things like Array[String] that's straightforward to implement, but what if we have property types like java.util.Map, or a random object?

[bbrehm]

👍 Good find!

I made setEdgeProperty also cow.

, but what if we have property types like java.util.Map, or a random object?

Not supported by flatgraph.

[mpollmeier]

👍🏻 thank you

[mpollmeier]

wouldn't it be better to just add this case to cloneThing?
i.e.

        case a: Array[_] =>
          a.clone()

[mpollmeier]

I'd prefer #163
But if you prefer this variant, we can go with this as well.

[mpollmeier]

switching to #163