Reverse NightMode switch state in HomeKit #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night Mode switch renamed LED. Reverse switch function so that it behaves like a normal light switch. Either the Fan LED is ON or OFF. This helps with Siri Commands like "Turn of all the lights". The Fan LED light then get put into "Night Mode" or an OFF setting. This approach is far more logical within the HomeKit ecosystem.
DysonNightMode ON = HomeKit Fan LED light OFF
this.nightMode ? false : true
|
not sure if I was correct in reversing the nightMode functionality in DysonLinkDevice.js as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joe-ng
This is so NightMode switch behaves as an LED light in HomeKit.
DysonNightMode ON = HomeKit Fan LED light OFF
Its a far more logical approach for HomeKit. Siri Commands like "Turn of the lights" in a given room switch the Dyson nightMode to ON