Support introspecting Pydantic model attributes #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is simply to change the order of `proxy` and `attr` in the comarision so that `proxy`'s known implementation is used instead of the Pydantic model's implementation. This fixes an infinite recursion error in the introspection done when creating an actor proxy.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 14 14
Lines 554 554
Branches 47 47
=======================================
Hits 517 517
Misses 32 32
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is simply to change the order of
proxyandattrin thecomparision so that
proxy's known implementation is used instead of thePydantic model's implementation.
This fixes an infinite recursion error in the introspection done when
creating an actor proxy.