-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.13 support #673
Open
jobovy
wants to merge
15
commits into
main
Choose a base branch
from
python-3.13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 99.91% 97.75% -2.16%
==========================================
Files 200 200
Lines 29325 29325
Branches 563 564 +1
==========================================
- Hits 29299 28666 -633
- Misses 26 659 +633 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue just tracks progress to fully changing the build/test infrastructure to Python 3.13. Python 3.13 wheels were already added in #674 and will be part of the next 1.10.1 release.
This PR tracks progress towards fully supporting Python 3.13. Any necessary fixes will be done separately outside of this PR, so actual Python 3.13 support can be achieved for many platforms before achieving it for all. We believe, in fact, that galpy fully works, but it is hard to fully test until all dependencies support Python 3.13.
Current status:
JAX
ornumba
, because they do not support Python 3.13 yet. This affects only the spherical DFs (forJAX
) and the non-inertial-frame force tests. There appears to be an issue with use ofpynbody
inSnapshotRZPotential
SnapshotRZPotential
``pynbody` issueJAX
-dependent codenumba
-dependent code