Stop ack-ing unprocessed pubsub messages and log warnings #2
Conversation
| } | ||
| $handledMessages[] = $message; |
There was a problem hiding this comment.
There's plenty of service that don't and won't get a handler for the message, meaning message will never get acked and will be retried many times. Don't think that's the aim here.
There was a problem hiding this comment.
Ah, you're right. The goal of this PR is to stop ack-ing the pubsub messages for the events that are registered in handlers array of app-events.php but does not have the relevant proto class in mappings array of the same file. But I just noticed that I need to change the AppEventFactory for that, too. Will add changes in a minute. I'll see what I can change to reach that goal.
There was a problem hiding this comment.
Took a bit more change to make that happen and I fall into the trap of updating everything unrelated but necessary.
|
With the latest changes, I will publish this as a new major version. |
The problem with current code is that if we forget to add a proto class to mappings, but add the event handler, the relevant pubsub messages will be discarded. That's not desirable. We want to not acknowledge the messages if the event is unprocessable.