Skip to content

Add groups number, phase size and round number to the state #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

TwilCynder
Copy link
Contributor

Title pretty much says all.
I think these can be very useful if users want to implement custom match names, most importantly if you have multiple groups in the current phase, which leads start.gg to give you pretty unintuitive round names (relative to the phase instead of the entire bracket, and i'm pretty sure a lot of viewers, who don't aren't aware of how the bracket is organized or just don't know how brackets work, might be confused to see a Winner Quarters displayed as Winner Finals). The info i added allow the overlays to be aware of what is the actual current round, relative to the tournament.

@ZombieHDGaming
Copy link
Collaborator

Honestly, I still gotta wrap my head around what the new info is supposed to show, but hey, info is info. My only concern is the removal of the bracket type pull in the set data, which I need to determine upset factor stuff. If that can be added back in the query, I think this should be alright.

@Wolfy76700
Copy link
Collaborator

I was thinking, would it be possible to use the presence of a progression out to not trigger Winners/Losers Quarters onwards text and instead continue counting progression numerically for those phases specifically?

@joaorb64
Copy link
Owner

joaorb64 commented Sep 11, 2023

I think an extension of this would be to generate more "global" names and even have the option to have names like "top 32" or something instead of "Winners Round 3"...? A plain round number doesn't say much, come to think about it.

@TwilCynder
Copy link
Contributor Author

I think an extension of this would be to generate more "global" names and even have the option to have names like "top 32" or something instead of "Winners Round 3"...? A plain round number doesn't say much, come to think about it.

@joaorb64 That's exactly what i was thinking !

I was thinking, would it be possible to use the presence of a progression out to not trigger Winners/Losers Quarters onwards text and instead continue counting progression numerically for those phases specifically?

@Wolfy76700 Yeah that could be a way to use the round number info indeed, not the one i was thinking about

Honestly, I still gotta wrap my head around what the new info is supposed to show, but hey, info is info. My only concern is the removal of the bracket type pull in the set data, which I need to determine upset factor stuff. If that can be added back in the query, I think this should be alright.

Oh damn i was not supposed to delete anything, that's definitely a missclick, fixing that

@TwilCynder
Copy link
Contributor Author

TwilCynder commented Sep 11, 2023

So yeah, as i was saying what i had in mind was more "global" round names as shino said, and there are 2 main ways to achieve that using the info i want to provide

  • using the group count value. If start.gg says "Winner Semis" and we have 2 groups, we know it's actually a Winner Quarters set, basically. Dosn't really give us "Global" round numbers but we can get more accurate ones.
  • By using the number of rounds to the end (GF = 0, WF = 1, WQ = 4 etc), which can be calculated using the phase size and the round number. HOWEVER the round number appears to be broken atm for losers bracket, I just can't make any sense of the values start.gg gives me.

So, before this PR is merged i think i should try to understand what's going on with losers round numbers, and then maybe have TSH do the "numbers of rounds to the end" calculation and put that in the state.

@Wolfy76700
Copy link
Collaborator

Wolfy76700 commented Sep 11, 2023

I think an extension of this would be to generate more "global" names and even have the option to have names like "top 32" or something instead of "Winners Round 3"...? A plain round number doesn't say much, come to think about it.

I definitely think having a toggle between both is good, but at the same time I also think it's important to always keep track (in double elimination) of when Winners is happening and when Losers is happening, so something like "Winners Top 32" or "Losers Top 24"

NB: I probably need to study bracketology more to have the exact names for these rounds

@joaorb64
Copy link
Owner

There's also another option, which is to get the next phase name and use round numbers until we get to PHASE qualifiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants