Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CMake script #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Modernize CMake script #15

wants to merge 3 commits into from

Conversation

benvenutti
Copy link

Hello there, in this PR I did a small refactoring on the original CMake script to give it a bit of a modern CMake approach. To achieve that, the minimum version of CMake was bumped to 3. The idea was to:

  • remove compiler specific flags;
  • avoid global project modifiers (for example, include_directories);
  • avoid globs (those can be a pain when working with build caches).

I also added a gitignore file (to help on out-of-source builds) and some extra information of the README file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant