This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
Add url and send_after options #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for reusing my work :) |
|
@hsamadi thanks for your PR! :D Can you just check the build status, please? Looks like a PEP8 issue happened. It looks awesome, by the way. 👍 |
|
Sure. I'm a little busy but I'll do that ASAP. |
joaobarbosa
suggested changes
Sep 20, 2019
| @@ -174,7 +174,8 @@ def get_payload_for_request(self): | |||
| payload = { | |||
| 'app_id': self.app_id, | |||
| # Should change when template/content_available support be done | |||
| 'contents': self.contents | |||
| 'contents': self.contents, | |||
| 'android_accent_color': 'FFE42D1F', | |||
There was a problem hiding this comment.
What about making android_accent_color a property in the class?
joaobarbosa
reviewed
Sep 20, 2019
| # Mode related settings | ||
| if self.mode == self.DEVICES_MODE: | ||
| payload.update({'include_player_ids': self.include_player_ids}) | ||
|
|
||
| # Common parameters | ||
| if len(self.data) > 0: | ||
| payload.update({'data': self.data}) | ||
| payload.update({'data': self.data}) |
There was a problem hiding this comment.
Why did you remove the verification? I didn't understand 🤔
joaobarbosa
suggested changes
Sep 20, 2019
| } | ||
|
|
||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new method was also added by @dolohow for retrieving device information.