Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed python 3.7, added 3.10 to github workflow #62

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

thanushipeiris
Copy link
Contributor

@thanushipeiris thanushipeiris commented Apr 20, 2022

Sorry for randomly trying this! You mentioned it in #58 and I wanted to understand github workflows a bit better.

Basically just followed the example in the readme here and committed every time I changed something until the tests started passing again.

Added quotations in the yml as otherwise 3.10 gets recognised as 3.1

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #62 (20c1c53) into main (53aac54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files           4        4           
  Lines         141      141           
=======================================
  Hits          117      117           
  Misses         24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53aac54...20c1c53. Read the comment docs.

@jni
Copy link
Owner

jni commented Apr 21, 2022

Haha "I apologise for helping your project along!" 😂 Thank you very much @thanushipeiris! 👏

@jni jni merged commit 6d235f9 into jni:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants