Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #26

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Tutorial #26

wants to merge 5 commits into from

Conversation

VolkerH
Copy link

@VolkerH VolkerH commented Feb 16, 2021

Hi @jni

I recently used affinder to register some MALDI datasets.
I think napari will be a useful manual fallback for other users in our lab in the rare cases where automated registration fails.
I was planning to write up a short tutorial for our lab members over the coming week but realise this could actually serve as a general tutorial for the project.

Just flagging this early with this WIP PR to make sure we don't duplicate efforts. (currently this is only a placeholder)

@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #26 (80fc273) into master (b538689) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #26   +/-   ##
======================================
  Coverage    3.84%   3.84%           
======================================
  Files           5       5           
  Lines         104     104           
======================================
  Hits            4       4           
  Misses        100     100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b538689...80fc273. Read the comment docs.

@VolkerH VolkerH changed the title WIP: how to use tutorial Tutorial Feb 19, 2021
@VolkerH
Copy link
Author

VolkerH commented Feb 19, 2021

Hi @jni. While I haven't proof-read and checked for typos I think this is ready for review. Feel free to push to my branch.

@jni
Copy link
Owner

jni commented Feb 22, 2021

Hi @VolkerH! This is great! I'd like to avoid including screenshots and gifs in the repo, as they can bloat the repo size very quickly and are fast to get out of date. Ideally, we would use the napari nbscreenshot functionality, and scikit-image for sample data. As a first step I'd be ok with just including the text and no screenshots.

@VolkerH
Copy link
Author

VolkerH commented Feb 22, 2021

Ok, I will keep this version then for use in our group but for affinder in general remove images and sample data from this PR.
Will have to re-read/re-write the text to make sure it can stand on its own. Will be few days though.

@jni
Copy link
Owner

jni commented Dec 14, 2021

@VolkerH some interesting ideas for adding screenshots to tutorials in this or other repos:

https://twitter.com/billba/status/1470166672283615232

ie, add the pngs/gifs/mp4s here as comments, then link to them. Apparently this is pretty common practice! 😂 The twitter threads suggest people have a dedicated issue for the things, but I think it's quite natural for the images to go on the PR in which they are added.

@VolkerH
Copy link
Author

VolkerH commented Dec 14, 2021

Maybe there is a Fuse FS driver that will open issues, encode files as images and add themto issues transparently :-)
Free cloud storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants