Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16slim/audit fixes #3

Open
wants to merge 7 commits into
base: 16slim/basic_strategy
Choose a base branch
from
Open

16slim/audit fixes #3

wants to merge 7 commits into from

Conversation

16slim
Copy link
Collaborator

@16slim 16slim commented Mar 23, 2022

Audit fixes corresponding to DDoZ9's review:

  1. Issue#01: Writing yo storage before an external call
  2. Issue#02: Use SafeCast when possible
  3. Issue#04: SafeMath for a subtraction operation
  4. Eliminate for loops for account portfolio actions as strategies will only have one position at a time
  5. Correct type definition of minAmountWant

@16slim
Copy link
Collaborator Author

16slim commented Mar 23, 2022

All tests passing:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@16slim