Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20220323 - Audit fixes #2

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

20220323 - Audit fixes #2

wants to merge 63 commits into from

Conversation

16slim
Copy link
Collaborator

@16slim 16slim commented Mar 23, 2022

Audit fixes corresponding to DDoZ9's review:

  1. Issue#01: Writing yo storage before an external call
  2. Issue#02: Use SafeCast when possible
  3. Issue#04: SafeMath for a subtraction operation
  4. Eliminate for loops for account portfolio actions as strategies will only have one position at a time
  5. Correct type definition of minAmountWant

16slim and others added 30 commits December 19, 2021 19:16
@16slim
feat:setup commit
82846ab
@16slim
feat: lend ETH script
3247025
@jmonteer
feat: depositing to notional working
7156060
@16slim
feat: implemented basic version of adjustPosition
17cc3f8
@16slim
feat: first implementation of prepareReturn and liquidatePosition
94afbc2
@16slim
fix: scale down fcash 95% to avoid reverting trades
6109bed
@16slim
feat: added functionality to settle and close all mature positions
e9cd436
@16slim
feat: initial liquidatePosition function
322379f
@16slim
feat: liquidate poitions based on current portfolio and active market…
b63aa5e 
…s + liquidateallpositions looping through current portfolio
@16slim
feat: included active market valuation in estimateTotalAssets
061836f
@16slim
fix: included all changes from PR#1
1a9ab2f
@jmonteer
chore: comments and minor changes
cc13631
@16slim
fix: Added comment explaining getmarketindex
061ff31
@16slim
Merge branch '16slim/basic_strategy' of https://github.com/jmonteer/n…
6243f92 
…otional-lending-strategy into 16slim/basic_strategy
@16slim
feat: test_profitable_harvest implemented
dd06dc2
@16slim
feat: profitable and lossy unit tests implemented
471d17a
@16slim
feat: unit tests for choppy harvest implemented
b3af1f1
@16slim
feat: implemented choppy and maturity unit tests for all notional tokens
67808e9
@16slim
feat: natspec docs on all functions
e93e102
@16slim
feat: created migration test for all tokens
f710e98
@16slim
feat: added @jmonteer comments from PR#1, notably not reporting profi…
68eb316 
…ts until maturity
@16slim
fix: added license for missing files
6c71d9b
@16slim
feat: included toggle to realize losses and rollout trade to change m…
e135b45 
…aturities
@16slim
fix: minor bug fixes and tests
f1c3509
@16slim
fix: change losses toggle to let users withdraw
e4be12c
@16slim
fix: moved the weth deposit to the trading function
1b6a4a1
@16slim
feat: changed to initializer pattern to enable strategy cloning
b5cbbd6
@16slim
feat: Implemented the fcash scaling factor to avoid potential reverts…
eb30c96 
… when entering positions
@16slim
fix: included DD link in README
83a4cc5
@16slim
fix: changed value of FCASH_SCALING a bit lower
cd56215
16slim and others added 30 commits January 28, 2022 20:14
@16slim
fix: added comments from peer review from @garywackett55
393ccec
@16slim
feat: implemented harvestTrigger logic
04af422
@16slim
fix: incorporated @storming0x comments from review
c5745c6
@16slim
feat: included comments from @storming0x from review
09f9958
@16slim
fix: changed tests to use live vault contracts from each token instea…
7a091f6 
…d of deploying a new one
@16slim
feat: added harvestTrigger() tests to test_maturity
950c09f
@16slim
fix: included new vault for weth testing
441de37
feat: added hardhat-fork as default network
fdc7adb
feat: added new external liquidation functions for onlyVaultManagers …
e71ee19 
…to operate the strat manuallyif needed
feat: added hardhat dependency
d4ce95b
feat: testing new external functions
756f25b
fix: minor fixes as per @jmonteer review
718ea99
fix: removed unused lendETH script
511f9c2
fix: moved manual operation tests into their own .py
183fe4a
fix: minor gas savings in preparereturn and adjustPosition as per @jm…
387d55e 
…onteer review
feat: included MIN_AMOUN_HARVEST variable + setter for harvestTrigger…
4a06e72 
… logic (and necessary changes in tests)
fix: Changed modifier for transferMarket to onlyGovernance and change…
ac0eb6a 
…d ONE constant to WETH as per @storming0x comments
feat: inluded a test for second initilization of both initial strateg…
67f7912 
…y and cloned strategy in test_clone.py as per @storming0x comment
@16slim
fix: comments edits
8125820
@16slim
fix: all tests are done with a cloned strategy to re-create real worl…
6f75be7 
…d situation
@16slim
feat: script re-creating the real step up scenario to run for Notiona…
a70fd45 
…l strat
@16slim
feat: changed tests to use deployed contract
33cf4e9
@16slim
fix: changed deployment script to use real cloned addresses
8a5a9bf
@16slim
fix: Moved storage writings before external calls as per auditor issue …
e3edeca 
…#1
@16slim
fix: perform substratction using safemath as per auditor issue#04
bb56267
@16slim
fix: eliminate account portfolio for loops as per auditor comment as …
5cc8766 
…these strategies fill only have one position at a time
@16slim
fix: update minAmountWant declaration to uint256
e1cf4e8
@16slim
fix: casts are performed using SafeCast when possible as per auditor …
a7cd83b 
…issue#02
@16slim
fix: included custom safe casting functions to int88, uint88 and uint40
2b33dc1
@16slim
chore: changed values of whale dumps and deploy strategy
fdea9a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@16slim @jmonteer