Lending Strategy #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s + liquidateallpositions looping through current portfolio
jmonteer
commented
Dec 28, 2021
|
do this
|
jmonteer
commented
Dec 30, 2021
…otional-lending-strategy into 16slim/basic_strategy
jmonteer
commented
Jan 14, 2022
jmonteer
commented
Jan 14, 2022
fp-crypto
reviewed
Jan 20, 2022
| // closing the position early | ||
| // This function is supposed to be called after _checkPositionsAndWithdraw() so the matured positions | ||
| // are supposed to already be included in the contract's want balance | ||
| return balanceOfWant() |
There was a problem hiding this comment.
Should this include ETH balance when the want is WETH?
There was a problem hiding this comment.
Shouldn't be needed as all the ETH interactions with Notional are wrapped with weth.withdraw or weth.deposit so the strategy never has an ETH balance. Just in case the strategy also implements a function to sweep any potential ETH to governance (function sendETHToGovernance)
fp-crypto
reviewed
Jan 20, 2022
fp-crypto
reviewed
Jan 20, 2022
…d of deploying a new one
…to operate the strat manuallyif needed
… logic (and necessary changes in tests)
…d ONE constant to WETH as per @storming0x comments
…y and cloned strategy in test_clone.py as per @storming0x comment
16slim
added a commit
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.