feat: 404 for unknown pages

jmlweb · Jul 27, 2023 · 52fe0de · 52fe0de
1 parent e9c8098
commit 52fe0de
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/apps/web/src/app/caracteristica/[slug]/[[...currentPage]]/page.tsx b/apps/web/src/app/caracteristica/[slug]/[[...currentPage]]/page.tsx
@@ -1,4 +1,5 @@
 import { Metadata, ResolvingMetadata } from 'next';
+import { notFound } from 'next/navigation';
 
 import { Container } from '@/components/Container';
 import { ItemsGrid } from '@/components/ItemsGrid';
@@ -30,6 +31,9 @@ export const generateMetadata = async (
   const data = await dataService.findBeaches(Number(currentPage), (beach) =>
     beach.features.includes(slug),
   );
+  if (!data.beaches.length) {
+    notFound();
+  }
   const previousImages = (await parent).openGraph?.images || [];
   const selectedBeach = data.beaches.find((beach) => beach.picture);
   const selectedImage = selectedBeach

diff --git a/apps/web/src/app/lista-playas/[[...currentPage]]/page.tsx b/apps/web/src/app/lista-playas/[[...currentPage]]/page.tsx
@@ -1,4 +1,5 @@
 import { Metadata, ResolvingMetadata } from 'next';
+import { notFound } from 'next/navigation';
 
 import { Container } from '@/components/Container';
 import { ItemsGrid } from '@/components/ItemsGrid';
@@ -22,6 +23,9 @@ export const generateMetadata = async (
   parent: ResolvingMetadata,
 ): Promise<Metadata> => {
   const data = await dataService.findBeaches(Number(currentPage));
+  if (!data.beaches.length) {
+    notFound();
+  }
   const previousImages = (await parent).openGraph?.images || [];
   const selectedBeach = data.beaches.find((beach) => beach.picture);
   const selectedImage = selectedBeach

diff --git a/apps/web/src/app/municipio/[slug]/[[...currentPage]]/page.tsx b/apps/web/src/app/municipio/[slug]/[[...currentPage]]/page.tsx
@@ -1,4 +1,5 @@
 import { Metadata, ResolvingMetadata } from 'next';
+import { notFound } from 'next/navigation';
 
 import { Container } from '@/components/Container';
 import { ItemsGrid } from '@/components/ItemsGrid';
@@ -58,6 +59,10 @@ const Municipality = async ({
     (beach) => beach.municipality === slug,
   );
 
+  if (!data.beaches.length) {
+    notFound();
+  }
+
   return (
     <Container fixed>
       <ItemsSectionHeader