Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding and operator #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding and operator #5

wants to merge 1 commit into from

Conversation

amir-sabbaghi
Copy link

No description provided.

@mtdowling
Copy link
Contributor

Sweet! Could you add the and related compliance tests as part of this commit? Unfortunately, this repo is a slight bit behind other JMESPath implementations, so it might require cherry-picking out the tests that are relevant to "&&".

  1. Compliance tests: https://github.com/jmespath/jmespath.test/tree/master/tests
  2. jmespath.lua tests: https://github.com/jmespath/jmespath.lua/tree/master/spec/compliance

@amir-sabbaghi
Copy link
Author

Current tests in master does not pass completely. There are errors in multiselect and functions tests.
And boolean tests does not pass completely because it cannot parse expressions which contain parentheses. I'm working on them. But I will make separate pull requests for these fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amir-sabbaghi @mtdowling