Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux/macOS fix #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Linux/macOS fix #12

wants to merge 1 commit into from

Conversation

rkarlsba
Copy link

Linux/macOS writes version to stderr, not stdout

Linux/macOS writes version to stderr, not stdout
@rkarlsba
Copy link
Author

Linux/macOS writes version to stderr, not stdout, so the code needs to be changed a wee bit

@jmerc77
Copy link
Owner

jmerc77 commented Jun 24, 2023

some curiosities:

  • am i right that the replace line is removed due to redundancy?
  • did the .err version fail on windows (is it not on both err and out?) if not the if is unnecessary.
  • what about win64? will it fail there?
  • wondering if there are openSCAD versions the use out on linux. something to consider. though hard to test.

@jmerc77
Copy link
Owner

jmerc77 commented Jun 24, 2023

did the .err version fail on windows (is it not on both err and out?) if not the if is unnecessary.

some say there's no such thing as a "stupid question." I disagree. if err and out were used it would print twice. which is undesirable behavior thus, answering the "stupid question" above from point 2. but at least I caught it before someone pointed it out which is better than if I didn't.

PS: there is a "best practice" to pointing out a "stupid question." explain why the question is self-answering. or in this case, point out the oversight and state that it should lead to the answer but also help them determine the reasoning. basically don't bluntly say its a "stupid question" ;-)

PSS: that "stupid question" stuff is partially for humor. feel free to chuckle.

@rkarlsba
Copy link
Author

I don't have a windows machine with python and git and all - only a tiny vm for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants