Convert to Swift 3.1 & other upgrades. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 3, 2017 22:39
The table wasn't using auto-layout so you could not scroll to the lower rows of the table - it was off the screen. Now fixed, should also mean it works better on different sized screens. Fix bug introduced with Swift 3.1 upgrade where the URLDataSessionTask in the UIImage extension was not resumed after creation and thus did nothing. Fix code that altered the UI from the background thread - this will crash the app and make it generally unstable - but does not work from the autolayout engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to Swift 3.1 - Xcode 8.3.3
Use URLSession instead of NSURLConnection (which is deprecated)
Make callbacks from web-requests run UI changes on main thread
Load APISecret & Key from a file if desired