Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: minor perf improvements and typing changes #52

Merged
merged 11 commits into from
Oct 12, 2023
Merged

refactor: minor perf improvements and typing changes #52

merged 11 commits into from
Oct 12, 2023

Conversation

micalevisk
Copy link
Contributor

see the commit messages

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: a059a4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nestjs-spelunker Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@jmcdo29 jmcdo29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few other spots where we can use for or

src/exploration.module.ts Outdated Show resolved Hide resolved
src/exploration.module.ts Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
@micalevisk micalevisk requested a review from jmcdo29 October 12, 2023 21:44
@jmcdo29
Copy link
Owner

jmcdo29 commented Oct 12, 2023

@micalevisk all looks good, ready for me to merge?

@micalevisk
Copy link
Contributor Author

@jmcdo29 yep

@jmcdo29 jmcdo29 merged commit edbc834 into jmcdo29:main Oct 12, 2023
@micalevisk micalevisk deleted the refactor-with-minor-perf-improv branch October 12, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants