Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change split args string #276

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fjodor-rybakov
Copy link

@fjodor-rybakov fjodor-rybakov commented Feb 9, 2022

At the moment, it is not possible to make a space in the name of the command argument. This pull request fixes this issue.

@nx-cloud
Copy link

nx-cloud bot commented Feb 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 67443c9. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

⚠️ No Changeset found

Latest commit: 67443c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmcdo29
Copy link
Owner

jmcdo29 commented Feb 9, 2022

it is not possible to make a space in the name of the command argument.

Does commander itself support that by default? Huh, TIL. Could you add to the integration tests to show that this provides the expected functionality? And after that, can you run the changeset wizard to make a patch change for this? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants