Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#39 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#39 #34

wants to merge 1 commit into from

Conversation

Fahima-Islam
Copy link
Collaborator

Description of work.

To test:

Fixes #xxxx.

Release Notes


Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the [coding standards]?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @qef/gatekeepers will take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant