modify command exception to use message instead of reason #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request for hydrate-reminder! |
👇 Click on the image for a new way to code review
Legend |
jmakhack
approved these changes
Oct 16, 2022
There was a problem hiding this comment.
The changes look good @ron-huberfeld
Thanks for the contribution! :)
|
@all-contributors please add @ron-huberfeld for code |
|
I've put up a pull request to add @ron-huberfeld! 🎉 |
|
Congrats on merging your first pull request to hydrate-reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue
Closes #352
Implemented Solution
Modify command exception to use message instead of reason.
Missing a test for NotSupportedCommandException.
Testing Details
Operating System: Windows
RuneLite Version: 1.9.1
Screenshots