Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename variables as per Codacy review #338

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

A-5ingh
Copy link
Contributor

@A-5ingh A-5ingh commented Oct 12, 2022

Associated Issue

Closes #333

Implemented Solution

Corrected the variable names and occurrences as per Pascal casing.

Testing Details

Operating System: MacOS 12.6
RuneLite Version: 1.1.1

Screenshots

@ghost
Copy link

ghost commented Oct 12, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@A-5ingh A-5ingh changed the title Rename variables as per Pascal casing Rename variables as per Codacy Oct 12, 2022
@A-5ingh A-5ingh changed the title Rename variables as per Codacy fix: rename variables as per Codacy review Oct 12, 2022
@A-5ingh A-5ingh force-pushed the refactor/fix-naming-convention branch from d19d9f6 to 025ec32 Compare October 12, 2022 18:50
@jmakhack jmakhack added this to the Ongoing milestone Oct 12, 2022
Copy link
Owner

@jmakhack jmakhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-5ingh, the changes look good and I've verified they are reported as fixed on Codacy.

Thanks for the contribution! :)

@jmakhack
Copy link
Owner

@all-contributors please add @A-5ingh for code

@allcontributors
Copy link
Contributor

@jmakhack

I've put up a pull request to add @A-5ingh! 🎉

@A-5ingh
Copy link
Contributor Author

A-5ingh commented Oct 12, 2022

@A-5ingh, the changes look good and I've verified they are reported as fixed on Codacy.

Thanks for the contribution! :)

No worries! If there are other issues which are not taken up by anyone I can contribute there as well.

@jmakhack jmakhack merged commit 6c2aedc into jmakhack:master Oct 12, 2022
@welcome
Copy link

welcome bot commented Oct 12, 2022

Congrats on merging your first pull request to hydrate-reminder!
Please give our project a star if you like what we are building here.
https://media.giphy.com/media/6RbEFpsxCOVOBUoJc4/giphy.gif

@jmakhack
Copy link
Owner

@A-5ingh, the changes look good and I've verified they are reported as fixed on Codacy.
Thanks for the contribution! :)

No worries! If there are other issues which are not taken up by anyone I can contribute there as well.

@A-5ingh now that hacktoberfest is slowing down with less contributors signing up for issues, you can take #332 as well if you'd like :)

@A-5ingh
Copy link
Contributor Author

A-5ingh commented Oct 12, 2022

@A-5ingh, the changes look good and I've verified they are reported as fixed on Codacy.
Thanks for the contribution! :)

No worries! If there are other issues which are not taken up by anyone I can contribute there as well.

@A-5ingh now that hacktoberfest is slowing down with less contributors signing up for issues, you can take #332 as well if you'd like :)

Sure, please assign #332 to me as well.

@A-5ingh A-5ingh deleted the refactor/fix-naming-convention branch October 12, 2022 21:31
@A-5ingh
Copy link
Contributor Author

A-5ingh commented Oct 12, 2022

@jmakhack can you please add the label hacktoberfest-accepted to this MR.

@jmakhack jmakhack added the hacktoberfest-accepted Accepted the pull request for hacktoberfest label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted the pull request for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[First Timers Only] Fix field naming conventions issues
2 participants