Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate ConsolePrompt methods et al #1148

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Undeprecate ConsolePrompt methods et al #1148

merged 1 commit into from
Jan 30, 2025

Conversation

quintesse
Copy link
Contributor

@quintesse quintesse commented Jan 8, 2025 •
edited
Loading

Implemented:

  • open()/close() methods for ConsolePrompt
  • calling open()/close() in prompt() methods that return Maps
  • removed @Deprecated annotations
  • removed new and unused (non Map returning) prompt() method
  • made new (non Map returning) prompt() method protected
  • fixed examples
  • made sure all ConsolePrompt fields are protected

Fixes #1141

@quintesse quintesse changed the title Undeprecate ConsolePrompt methods Undeprecate ConsolePrompt methods et all Jan 8, 2025
@quintesse quintesse changed the title Undeprecate ConsolePrompt methods et all Undeprecate ConsolePrompt methods et al Jan 8, 2025
@quintesse
Copy link
Contributor Author

Hi @mattirn , created this PR as a possible way to implement your suggestions from #1141

@quintesse
Copy link
Contributor Author

Any idea when we could get a release with this merged? 😅

@cstamas
Copy link
Contributor

cstamas commented Jan 30, 2025

I asked @gnodet about this, and adding/removing AutoCloseable already bite us once (see https://issues.apache.org/jira/browse/MNG-8439) and now this PR removes AutoCloseable 😄 so am unsure is .1 good fit for it (while we have bug fixes required for Maven 4). I am fine if Guillaume does 3.29.0 release with this PR.

@gnodet gnodet added this to the 3.29.0 milestone Jan 30, 2025
@gnodet gnodet merged commit a6a7786 into jline:master Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattirn mattirn mattirn approved these changes

@cstamas cstamas cstamas approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
3.29.0
Development

Successfully merging this pull request may close these issues.

Review ConsolePrompt's method visibilities
4 participants
@quintesse @cstamas @mattirn @gnodet