Remove sellerReturnReasonCode from ReturnItem (#706)

resources/metadata/modifications.json

@@ -1,5 +1,21 @@
 {
   "seller": {
+    "fba-outbound": {
+      "2020-07-01": [
+        {
+          "comment": "Remove required 'sellerReturnReasonCode', see https://github.com/jlevers/selling-partner-api/issues/706",
+          "action": "replace",
+          "path": "components.schemas.ReturnItem.required",
+          "value": [
+            "amazonShipmentId",
+            "sellerFulfillmentOrderItemId",
+            "sellerReturnItemId",
+            "status",
+            "statusChangedDate"
+          ]
+        }
+      ]
+    },
     "orders": {
       "0": [
         {

resources/models/seller/fba-outbound/v2020-07-01.json

@@ -4493,7 +4493,6 @@
                     "amazonShipmentId",
                     "sellerFulfillmentOrderItemId",
                     "sellerReturnItemId",
-                    "sellerReturnReasonCode",
                     "status",
                     "statusChangedDate"
                 ],

src/Generator/FileHandler.php

@@ -54,7 +54,7 @@ public function supportingFilePath(SupportingFile $type, PhpFile $file): string
         return $this->baseOutputPath($file, $type->value);
     }
 
-    protected function baseOutputPath(PhpFile $file, string $subPath = ''): string
+    protected function baseOutputPath(PhpFile $file, ?string $subPath = ''): string
     {
         if ($subPath && $subPath[0] !== '/') {
             $subPath = "/$subPath";

src/Seller/FBAOutboundV20200701/Dto/ReturnItem.php

@@ -12,9 +12,9 @@ final class ReturnItem extends Dto
      * @param  string  $sellerReturnItemId  An identifier assigned by the seller to the return item.
      * @param  string  $sellerFulfillmentOrderItemId  The identifier assigned to the item by the seller when the fulfillment order was created.
      * @param  string  $amazonShipmentId  The identifier for the shipment that is associated with the return item.
-     * @param  string  $sellerReturnReasonCode  The return reason code assigned to the return item by the seller.
      * @param  string  $status  Indicates if the return item has been processed by a fulfillment center.
      * @param  DateTime  $statusChangedDate
+     * @param  ?string  $sellerReturnReasonCode  The return reason code assigned to the return item by the seller.
      * @param  ?string  $returnComment  An optional comment about the return item.
      * @param  ?string  $amazonReturnReasonCode  The return reason code that the Amazon fulfillment center assigned to the return item.
      * @param  ?string  $returnAuthorizationId  Identifies the return authorization used to return this item. Refer to `ReturnAuthorization`.
@@ -25,9 +25,9 @@ public function __construct(
         public readonly string $sellerReturnItemId,
         public readonly string $sellerFulfillmentOrderItemId,
         public readonly string $amazonShipmentId,
-        public readonly string $sellerReturnReasonCode,
         public readonly string $status,
         public readonly \DateTime $statusChangedDate,
+        public readonly ?string $sellerReturnReasonCode = null,
         public readonly ?string $returnComment = null,
         public readonly ?string $amazonReturnReasonCode = null,
         public readonly ?string $returnAuthorizationId = null,

src/Seller/SellerConnector.php

@@ -42,7 +42,7 @@ public function easyShipV20220323(): EasyShipV20220323\Api
     {
         return new EasyShipV20220323\Api($this);
     }
-    
+
     public function fbaInboundV20240320(): FBAInboundV20240320\Api
     {
         return new FBAInboundV20240320\Api($this);