Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not showing error log when helm command failed #136

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

jlandowner
Copy link
Owner

Close #115

@jlandowner jlandowner added the bug Something isn't working label Aug 16, 2024
@jlandowner jlandowner merged commit 72a8a30 into main Aug 16, 2024
4 checks passed
@jlandowner jlandowner deleted the fix/helm-error branch August 16, 2024 00:10
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.53%. Comparing base (989b4bb) to head (d66fbd9).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/charts/snap.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   79.49%   79.53%   +0.03%     
==========================================
  Files          16       16              
  Lines        1024     1026       +2     
==========================================
+ Hits          814      816       +2     
  Misses        141      141              
  Partials       69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

success even if chart is not found
2 participants