add VK640 #63
Open
add VK640 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'll be fine approving this, but I don't know what events have to be emitted (I don't have such a device with tilt support, the older VEIKK devices don't). If I understand correctly, this adds another field to the report struct, but you will have to emit an event to actually implement the support. Let me know if I am understanding incorrectly. I am also worried that this may cause a minor issue on devices without tilt support, because their report struct is smaller and accessing the bytes afterwards is UB. If you do not end up using the tilt support, I may end up just committing the part adding the VK640 and not the change to the report struct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VK640 has tilt functionality extra param added to report