test #29

jlahoda · 2019-07-13T12:20:20Z

No description provided.

…ing Flow errors.

…ent compilation unit - compensating by using positions to find the proper path, also should improve speed.

jlahoda-jackpot · 2019-07-13T12:27:21Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+                throw (ThreadDeath) t;
+            }
+            boolean a = false;
+            assert a = true;


Jackpot:
warning: Assert condition produces side effects

jlahoda-jackpot · 2019-07-13T12:27:22Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+    private final Method typeEnterSuperCall;
+
+    public VanillaPartialReparser() {
+        Method unenter;


Jackpot:
warning: Local variable hides a field

jlahoda-jackpot · 2019-07-13T12:27:23Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+            unenter = null;
+        }
+        this.unenter = unenter;
+        Field lazyDocCommentsTable;


Jackpot:
warning: Local variable hides a field

jlahoda-jackpot · 2019-07-13T12:27:24Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+            lazyDocCommentsTable = null;
+        }
+        this.lazyDocCommentsTable = lazyDocCommentsTable;
+        Field parserDocComments;


Jackpot:
warning: Local variable hides a field

jlahoda-jackpot · 2019-07-13T12:27:25Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+            parserDocComments = null;
+        }
+        this.parserDocComments = parserDocComments;
+        Method lineMapBuild;


Jackpot:
warning: Local variable hides a field

jlahoda-jackpot · 2019-07-13T12:27:25Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+            lineMapBuild = null;
+        }
+        this.lineMapBuild = lineMapBuild;
+        Method typeEnterSuperCall;


Jackpot:
warning: Local variable hides a field

jlahoda-jackpot · 2019-07-13T12:27:26Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+            if (a) {
+                JavacParser.dumpSource(ci, t);
+            }
+            t.printStackTrace();


Jackpot:
warning: Print Stack Trace

jlahoda-jackpot · 2019-07-13T12:27:27Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/VanillaPartialReparser.java

+//        } catch (CouplingAbort ca) {
+//            //Needs full reparse
+//            return false;
+        } catch (Throwable t) {


Jackpot:
warning: Can be replaced with multicatch or several catch clauses catching specific exceptions

jlahoda-jackpot · 2019-07-13T12:27:28Z

...java.source.base/src/org/netbeans/modules/java/source/parsing/TranslatePositionsVisitor.java

+        }
+        if (active && node != null) {
+            Integer pos = endPos.replaceTree((JCTree) node, null);//remove
+            if (pos != null) {


Jackpot:
warning: Unnecessary test for null - the expression is never null

jlahoda-jackpot · 2019-07-13T12:27:29Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/FindAnonymousVisitor.java

+
+    int noInner;
+    boolean hasLocalClass;
+    final Set<Tree> docOwners = new HashSet<Tree>();


Jackpot:
warning: Redundant type arguments in new expression (use diamond operator instead).

jlahoda-jackpot · 2019-07-13T12:27:30Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/FindAnonymousVisitor.java

+import com.sun.source.tree.Tree;
+import com.sun.source.tree.VariableTree;
+import org.netbeans.api.java.source.support.ErrorAwareTreeScanner;
+import com.sun.tools.javac.tree.JCTree.JCClassDecl;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-07-13T12:27:30Z

java/java.source.base/src/org/netbeans/modules/java/source/parsing/FindAnonymousVisitor.java

+import com.sun.tools.javac.tree.JCTree.JCClassDecl;
+import java.util.HashSet;
+import java.util.Set;
+import org.netbeans.lib.nbjavac.services.NBTreeMaker.IndexedClassDecl;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-07-13T12:27:36Z

...a.source.base/test/unit/src/org/netbeans/modules/java/source/parsing/PartialReparseTest.java

+        Document doc = ec.openDocument();
+        JavaSource source = JavaSource.forFileObject(src);
+        Object[] topLevel = new Object[1];
+        source.runUserActionTask(cc -> {


Jackpot:
warning: Dereferencing possible null pointer

jlahoda-jackpot · 2019-07-13T12:27:36Z

...a.source.base/test/unit/src/org/netbeans/modules/java/source/parsing/PartialReparseTest.java

+        Document doc = ec.openDocument();
+        JavaSource source = JavaSource.forFileObject(src);
+        Object[] topLevel = new Object[1];
+        source.runUserActionTask(cc -> {


Jackpot:
warning: Dereferencing possible null pointer

jlahoda-jackpot · 2019-07-13T12:27:37Z

...a.source.base/test/unit/src/org/netbeans/modules/java/source/parsing/PartialReparseTest.java

+            if (!Objects.equals(this.docComment, other.docComment)) {
+                return false;
+            }
+            if (this.kind != other.kind) {


Jackpot:
warning: The if statement is redundant

jlahoda-jackpot · 2019-07-13T12:27:38Z

...a.source.base/test/unit/src/org/netbeans/modules/java/source/parsing/PartialReparseTest.java

+            if (this.kind != other.kind) {
+                return false;
+            }
+            if (!Objects.equals(this.source, other.source)) {


Jackpot:
warning: The if statement is redundant

jlahoda-jackpot · 2019-07-13T12:27:39Z

...a.source.base/test/unit/src/org/netbeans/modules/java/source/parsing/PartialReparseTest.java

+        super(name);
+    }
+
+    protected void setUp() throws Exception {


Jackpot:
warning: Add @OverRide Annotation

jlahoda-jackpot · 2019-07-13T12:27:40Z

java/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBLog.java

@@ -41,7 +43,10 @@

    private final Map<URI,Collection<Symbol.ClassSymbol>> notInProfiles =
            new HashMap<>();
-
+


Jackpot:
warning: Field seenPartialReparsePositions can be final

jlahoda-jackpot · 2019-07-13T12:27:41Z

java/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavacTrees.java

@@ -29,6 +29,8 @@
 import com.sun.tools.javac.util.Context;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.logging.Level;
+import java.util.logging.Logger;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-07-13T12:27:41Z

java/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavacTrees.java

@@ -29,6 +29,8 @@
 import com.sun.tools.javac.util.Context;
 import java.util.HashMap;
 import java.util.Map;
+import java.util.logging.Level;


Jackpot:
warning: Unused Import

jlahoda-jackpot · 2019-07-13T12:27:42Z

java/lib.nbjavac/src/org/netbeans/lib/nbjavac/services/NBJavacTrees.java

@@ -47,13 +49,25 @@ public JavacTrees make(Context c) {
            }
        });
    }


Jackpot:
warning: Constant name does not follow naming conventions: hasNbJavac

jlahoda added 11 commits May 22, 2019 18:38

A crude attempt for a partial reparse when using JDK's javac.

c351921

Adding forgotten test.

ce1f1ba

Progress on vanilla partial reparse.

76200b5

Adding verification of Elements and TypeMirrors into the tests; handl…

a875ef4

…ing Flow errors.

Adding another test for flow.

bd9775f

More progress on vanilla partial reparse.

9c8b214

Fixing LineMap after partial reparse.

14c643d

Constructor handling.

9a17be9

Merge branch 'master' into vanilla-partial-reparse

51bb91d

Seems that it may happen that orig method is not a tree from the curr…

06d6f93

…ent compilation unit - compensating by using positions to find the proper path, also should improve speed.

Avoiding dependency on IndexedClassDecl.

445e994

jlahoda-jackpot reviewed Jul 13, 2019

View reviewed changes

jlahoda added 4 commits November 3, 2019 19:00

Merge branch 'master' into vanilla-partial-reparse

1cbfb50

Disable the partial reparse by default.

13bc65a

Cleanup.

f912e1d

More cleanup.

dfde267

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test #29

test #29

jlahoda commented Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

jlahoda-jackpot Jul 13, 2019

		@@ -41,7 +43,10 @@

		private final Map<URI,Collection<Symbol.ClassSymbol>> notInProfiles =
		new HashMap<>();

@@ @@ -47,13 +49,25 @@ public JavacTrees make(Context c) { @@
                           }
                       });
                   }

test #29

Are you sure you want to change the base?

test #29

Conversation

jlahoda commented Jul 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment