Testing PR - java.lsp.server #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to java-lsp-server
…s/incubator-netbeans into java-lsp-server
| List<FileObject> projectCandidates = new ArrayList<>(); | ||
| List<WorkspaceFolder> folders = init.getWorkspaceFolders(); | ||
| if (folders != null) { | ||
| for (WorkspaceFolder w : folders) { |
There was a problem hiding this comment.
Jackpot:
warning: Can use functional operations
| } | ||
| } | ||
| List<Project> projects = new ArrayList<>(); | ||
| for (FileObject candidate : projectCandidates) { |
There was a problem hiding this comment.
Jackpot:
warning: Can use functional operations
| import java.io.InputStream; | ||
| import java.io.OutputStream; | ||
| import java.net.MalformedURLException; | ||
| import java.net.URL; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| import org.openide.filesystems.FileUtil; | ||
| import org.openide.modules.ModuleInfo; | ||
| import org.openide.modules.Places; | ||
| import org.openide.util.Exceptions; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| import org.netbeans.api.project.ui.OpenProjects; | ||
| import org.netbeans.modules.java.lsp.server.text.TextDocumentServiceImpl; | ||
| import org.netbeans.modules.java.lsp.server.workspace.WorkspaceServiceImpl; | ||
| import org.netbeans.modules.parsing.impl.indexing.DefaultCacheFolderProvider; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| import org.netbeans.modules.parsing.impl.indexing.DefaultCacheFolderProvider; | ||
| import org.netbeans.modules.parsing.impl.indexing.implspi.CacheFolderProvider; | ||
| import org.openide.filesystems.FileObject; | ||
| import org.openide.filesystems.FileUtil; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| //XXX: ensure project opened: | ||
| try { | ||
| Class.forName("org.netbeans.modules.project.ui.OpenProjectList", false, Lookup.getDefault().lookup(ClassLoader.class)).getDeclaredMethod("waitProjectsFullyOpen").invoke(null); | ||
| } catch (Exception ex) { |
There was a problem hiding this comment.
Jackpot:
warning: Can be replaced with multicatch or several catch clauses catching specific exceptions
|
|
||
| while (true) { | ||
| try { | ||
| Thread.sleep(100000); |
There was a problem hiding this comment.
Jackpot:
warning: Thread.sleep called in loop
| case RETURN: returnTags.add(tag); break; | ||
| case THROWS: throwsTags.add(tag); break; | ||
| case PARAM: paramTags.add(tag); break; | ||
| default: otherTags.add(tag); |
There was a problem hiding this comment.
Jackpot:
warning: Can use functional operations
| import com.sun.javadoc.MethodDoc; | ||
| import com.sun.javadoc.ParamTag; | ||
| import com.sun.javadoc.ThrowsTag; | ||
| import com.sun.javadoc.Type; | ||
| import com.sun.source.doctree.AttributeTree; | ||
| import com.sun.source.doctree.AuthorTree; | ||
| import com.sun.source.doctree.CommentTree; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
| import com.sun.source.tree.Tree; | ||
| import com.sun.source.util.DocSourcePositions; | ||
| import com.sun.source.util.DocTreePath; | ||
| import com.sun.source.util.DocTreePathScanner; | ||
| import com.sun.source.util.TreePath; | ||
| import com.sun.tools.doclint.HtmlTag; | ||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.Collections; |
There was a problem hiding this comment.
Jackpot:
warning: Unused Import
…old license by itself)
…y calling the correct superclass method instead of the synthetic bridge.
jlahoda
pushed a commit
that referenced
this pull request
Aug 7, 2022
The relevant stacktraces for the affected threads are saved below. As there is also a warning logged with a clear indication: WARNING [org.netbeans.modules.parsing.impl.TaskProcessor]: ParserManager.parse called in AWT event thread by: org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getPropertyName(MicronautJavaHyperlinkProvider.java:151) Stacktraces: "AWT-EventQueue-0" #24 prio=6 os_prio=0 cpu=69156.33ms elapsed=76496.39s tid=0x00007feca4122b90 nid=0x106e2a waiting on condition [0x00007fec9756e000] java.lang.Thread.State: WAITING (parking) at jdk.internal.misc.Unsafe.park([email protected]/Native Method) - parking to wait for <0x00000006d7905fd0> (a java.util.concurrent.locks.ReentrantLock$FairSync) at java.util.concurrent.locks.LockSupport.park([email protected]/LockSupport.java:211) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire([email protected]/AbstractQueuedSynchronizer.java:715) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire([email protected]/AbstractQueuedSynchronizer.java:938) at java.util.concurrent.locks.ReentrantLock$Sync.lock([email protected]/ReentrantLock.java:153) at java.util.concurrent.locks.ReentrantLock.lock([email protected]/ReentrantLock.java:322) at org.netbeans.modules.parsing.impl.TaskProcessor.runUserTask(TaskProcessor.java:170) at org.netbeans.modules.parsing.api.ParserManager.parse(ParserManager.java:83) at org.netbeans.api.java.source.JavaSource.runUserActionTaskImpl(JavaSource.java:454) at org.netbeans.api.java.source.JavaSource.runUserActionTask(JavaSource.java:425) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getPropertyName(MicronautJavaHyperlinkProvider.java:151) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.resolve(MicronautJavaHyperlinkProvider.java:122) at org.netbeans.modules.micronaut.hyperlink.MicronautJavaHyperlinkProvider.getHyperlinkSpan(MicronautJavaHyperlinkProvider.java:85) "Editor Parsing Loop (14-c4f2d87113e1a2d2d4e21e8952e1f99612d5b3fd)" #28 daemon prio=1 os_prio=0 cpu=65769.71ms elapsed=76494.46s tid=0x00007feca4401250 nid=0x106e35 in Object.wait() [0x00007fec957fe000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait([email protected]/Native Method) - waiting on <no object reference available> at java.lang.Object.wait([email protected]/Object.java:338) at org.netbeans.modules.parsing.impl.TaskProcessor$CurrentRequestReference.setCurrentTask(TaskProcessor.java:1128) - locked <0x00000006d75591d8> (a org.netbeans.modules.parsing.impl.TaskProcessor$CurrentRequestReference$CRRLock) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.run(TaskProcessor.java:842) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:279) at org.netbeans.modules.parsing.impl.TaskProcessor$RequestPerformer.execute(TaskProcessor.java:702) at org.netbeans.modules.parsing.impl.TaskProcessor$CompilationJob.run(TaskProcessor.java:663) "Module-Actions" apache#163 daemon prio=1 os_prio=0 cpu=2546.95ms elapsed=253.00s tid=0x00007fec806c9c90 nid=0x1abee2 in Object.wait() [0x00007fec951fa000] java.lang.Thread.State: WAITING (on object monitor) at java.lang.Object.wait([email protected]/Native Method) - waiting on <no object reference available> at java.lang.Object.wait([email protected]/Object.java:338) at javax.swing.text.AbstractDocument.writeLock([email protected]/AbstractDocument.java:1378) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) at org.netbeans.editor.BaseDocument.extWriteLock(BaseDocument.java:1696) at org.netbeans.editor.BaseDocument.atomicLockImpl(BaseDocument.java:1744) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) - locked <0x0000000718f28200> (a org.netbeans.modules.editor.NbEditorDocument) at org.netbeans.editor.GuardedDocument.runAtomicAsUser(GuardedDocument.java:329) at org.netbeans.modules.editor.lib.BeforeSaveTasks$TaskRunnable.run(BeforeSaveTasks.java:131) at org.netbeans.modules.editor.lib.TrailingWhitespaceRemove.runLocked(TrailingWhitespaceRemove.java:77)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.