Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter lint rules #377

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Stricter lint rules #377

merged 2 commits into from
Dec 20, 2024

Conversation

jkroepke
Copy link
Owner

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

  • fixes #

Special notes for your reviewer

Particularly user-facing changes

Checklist

Complete these before marking the PR as ready to review:

  • DCO signed
  • The PR title has a summary of the changes
  • The PR body has a summary to reflect any significant (and particularly user-facing) changes introduced by this PR

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke jkroepke merged commit 1a503b5 into main Dec 20, 2024
8 checks passed
@jkroepke jkroepke deleted the deps branch December 20, 2024 16:44
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (31f9f18) to head (a5f2bdb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/oauth2/provider.go 71.42% 2 Missing ⚠️
internal/oauth2/providers/github/api.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   82.73%   82.70%   -0.04%     
==========================================
  Files          51       51              
  Lines        3163     3162       -1     
==========================================
- Hits         2617     2615       -2     
- Misses        416      418       +2     
+ Partials      130      129       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant