This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
Improved English message #341
Open
gregariomansa
wants to merge
4
commits into
jkroepke:master
Choose a base branch
from
gregariomansa:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have rewritten some English text in the code. The modified file is ingame.php, in the language/en folder. The modifications are only in the English messages. I have made no change in the actual code.
Hi, |
Yes! I have identified a few more. But I would like to see these changes in
the game...
I started with steemnova. Sent them about 16 English improvements. They
have not answered.
I am curious about one thing. I have a user in 2moons, although I never
opened one. Looks like the user base for steemnova and 2moons is the same...
Anyway, I am delighted you have taken my contributions into account. Thanks
a lot for that!
Take care.
2018-02-06 21:45 GMT-03:00 Jan-Otto Kröpke <[email protected]>:
… Hi,
should I wait for more?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#341 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcJsP26O69fbmzW1fwvsd8lu3FnHoMCOks5tSPIegaJpZM4R75qo>
.
|
Fine. Let me know, when I should merge it. |
Finally the Steemnova team have incorporated my English changes. Can you pull them from them? So I won't have to post them again here. But neither in Steemnova nor here in 2moons I see the effective changes. I still see "no any online admininstrator" under Overview, Active Admins. It seems like the changes are not in place yet... |
Link?
You have to clear the cache. |
Hi, how are you doing?
I mentioned you in conversations in the steemnova discord. I'd like you to
see those conversations. Maybe you'd like to take a look.
https://discordapp.com/channels/404642952783069195/407118260023066634?jump=429269207939547138
2018-02-10 12:58 GMT-03:00 Jan-Otto Kröpke <[email protected]>:
… . Can you pull them from them? So I won't have to post them again here.
Link?
But neither in Steemnova nor here in 2moons I see the effective changes. I
still see "no any online admininstrator" under Overview, Active Admins. It
seems like the changes are not in place yet.
You have to clear the cache.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#341 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AcJsP9TKyjvp1H0r5EaxCuVZMZfpiBEWks5tTbyYgaJpZM4R75qo>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.