Skip to content

Commit

Permalink
infra: Always store logs of action Live ISO build
Browse files Browse the repository at this point in the history
Currently, it seems that if Makefile command to build Live ISO fails it
will stop execution of the next mv commands. Let's not move logs and
instead store them where they are created so we always collect them in
the next task.
  • Loading branch information
jkonecny12 committed Jun 5, 2024
1 parent f52880c commit 172fac9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/build-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ jobs:
mkdir -p images
make -f Makefile.am container-live-iso-build CI_TAG=$CONTAINER_TAG
mv result/iso/Fedora-Workstation.iso "images/${{ needs.pr-info.outputs.image_description }}-Fedora-Workstation.iso"
mv result/iso/logs images/
- name: Make artefacts created by sudo cleanable
if: always()
Expand All @@ -273,8 +272,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: 'logs'
path: |
images/logs/*
path: result/iso/logs/*

- name: Upload image artifacts
uses: actions/upload-artifact@v4
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/build-image.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ jobs:
mkdir -p images
make -f Makefile.am container-live-iso-build CI_TAG=$CONTAINER_TAG
mv result/iso/Fedora-Workstation.iso "images/${{ needs.pr-info.outputs.image_description }}-Fedora-Workstation.iso"
mv result/iso/logs images/

- name: Make artefacts created by sudo cleanable
if: always()
Expand All @@ -267,8 +266,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: 'logs'
path: |
images/logs/*
path: result/iso/logs/*

- name: Upload image artifacts
uses: actions/upload-artifact@v4
Expand Down

0 comments on commit 172fac9

Please sign in to comment.