Merge pull request spree-contrib#177 from InnovativeOperations/perfor…

…mance/use-exists-on-parts Use exists? on parts
jkelleyj · Apr 26, 2018 · dedf8b2 · dedf8b2
2 parents e7b875e + 17596ba
commit dedf8b2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/models/spree/product_decorator.rb b/app/models/spree/product_decorator.rb
@@ -18,7 +18,7 @@ def variants_or_master
   end
 
   def assembly?
-    parts.present?
+    parts.exists?
   end
 
   def count_of(variant)

diff --git a/app/serializers/spree/wombat/assembly_shipment_serializer.rb b/app/serializers/spree/wombat/assembly_shipment_serializer.rb
@@ -17,7 +17,7 @@ def items
               price: li.price.to_f
             }
 
-            if li.parts.present?
+            if li.parts.exists?
               bundled_items = []
               li.parts.each do |part|
                 bundled_items << {