Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify UserInfo Response #63

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hotgazpacho
Copy link

According to the OpenID Connect spec, for security reasons, we must verify that the subject of the UserInfo response matches the subject of the ID Token. If they do not match, then the client MUST discard the UserInfo response.

This pull request addresses that, as well as changes the uid to read from the ID Token and not the UserInfo response.

Fixes #62

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.553% when pulling c6588d3 on hotgazpacho:verify-userinfo-sub into 849b181 on jjbohn:master.

@hotgazpacho
Copy link
Author

Perhaps the Travis config needs to be updated to only build on Ruby 2.3? It passes on 2.3.
Or perhaps the gemspec needs to specify a looser version dependency on ActiveSupport?

@hotgazpacho
Copy link
Author

Seems like the downstream deps from @nov should be locking to a minimal version of ActiveModel/ActiveSupport. I suggest '>= 4.2', as that's the oldest supported version of Rails

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.553% when pulling b6096b9 on hotgazpacho:verify-userinfo-sub into 849b181 on jjbohn:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants