fix: missing dist on npm package #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #116
Currently, incremental compilation is enabled on our project. While it can speeds up builds by reusing information from previous compilations, it may leads to build issues. Like in our case, after we execute
shx rm -rf dist/*,tsc -p tsconfig.build.jsondoes not result anything since it does not detect any TS file changes.One solution is to remove generated
tsbuildinfolike what this PR does. If this is not a good solution, this second solution might be the choice: DisablingcompositeandincrementaloptionAny feedbacks are welcome @jjangga0214