[RFC] build: switch back to gix/max-performance-safe feature by default
#5047
+14
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynn1989
approved these changes
Dec 7, 2024
Cynn1989
approved these changes
Dec 7, 2024
yuja
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
iirc, @thoughtpolice's idea was to drop cmake dependency from lib-nz-sys. If that works, we won't need the feature flag.
We'll also need to revert the doc change b7ba3fc.
Using `gix/max-performance` requires `cmake` as a build-time dependency, which could be a significant barrier for contributors (including existing ones, like me, who already work on jj but didn't have `cmake` installed thus far). This commit switches back to using `gix/max-performance-safe`, which doesn't have the `cmake` dependency, and adds `gix/max-performance` behind the `gix-max-performance` feature for `jj-lib`. It also adds `gix-max-performance` to the `packaging` feature group, since I'm assuming that packagers will want maximum performance, and are more likely to have `cmake` at hand. Tested with ``` $ cargo build --workspace $ cargo build --workspace --features packaging ``` (and the `--features packaging` build failed until I installed `cmake`)
arxanas
force-pushed
the
arxanas/build-no-cmake
branch
from
27c6e19 to
defa823
Compare
That would be great 😄
Reverted in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message, plus discussions at
https://discord.com/channels/968932220549103686/1314478258636718081 and
https://discord.com/channels/968932220549103686/969291218347524238/1315041069032804383.
Before committing, I'll need to update the docs to clarify the
cmakedependency situation.Checklist
If applicable:
CHANGELOG.md