-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
documentation improved #2583
base: master
Are you sure you want to change the base?
documentation improved #2583
Conversation
Hi, thanks for your contribution! |
I have signed the CLA. kindly review my PR now |
JitsiConference.js
Outdated
@@ -367,11 +367,17 @@ JitsiConference.resourceCreator = function(jid, isAuthenticatedUser) { | |||
* @param options {object} | |||
* @param options.connection {JitsiConnection} overrides this.connection | |||
*/ | |||
|
|||
/** | |||
* Class JitsiConferenceOptions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be blended with the above comment since it describes the class already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes you suggested
@@ -366,12 +366,14 @@ JitsiConference.resourceCreator = function(jid, isAuthenticatedUser) { | |||
* Initializes the conference object properties | |||
* @param options {object} | |||
* @param options.connection {JitsiConnection} overrides this.connection | |||
* @property {string} [statisticsId] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this property?
statisticsId is part of the options.config ...
documented statisticsId field