Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jaas) add zero-config mode for JaaS customers #2502

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saghul
Copy link
Member

@saghul saghul commented Apr 12, 2024

No description provided.

@saghul
Copy link
Member Author

saghul commented Apr 12, 2024

@jallamsetty1 @damencho I had the following idea today.

Ideally I'd like to fullfil the dream of literraly zero config to get a meeting going, which seems to be within reach for JaaS customers.

The only thing I haven't figured out is how to add the room query parameter to the connection URLs, since we don't know it at that moment. Ideas?

@damencho
Copy link
Member

Not really. For the http requests to jicofo I needed it so I added it to the api, to be able to set it when creating connection.

@damencho
Copy link
Member

Or maybe it was when calling connect

@damencho
Copy link
Member

* @param options.name {string} The name of the room/conference we will be connecting to. This is needed on connection

Maybe it is worth moving the logic for these params from jitsi-meet into ljm.

https://github.com/jitsi/jitsi-meet/blob/d1590db82bf3fd1be8d4179db3df6c7ff7270048/react/features/base/connection/actions.any.ts#L151

@saghul
Copy link
Member Author

saghul commented Apr 12, 2024

Maybe it is worth moving the logic for these params from jitsi-meet into ljm.

Pretty much yeah.

Another option would be some JitsiMeetJS.joinConference(options) convenience function which creates a connection and then joins a conference. This way we could get everything we need there and piecemeal it to either the connection or the conference.

@jallamsetty1
Copy link
Member

Maybe it is worth moving the logic for these params from jitsi-meet into ljm.

Pretty much yeah.

Another option would be some JitsiMeetJS.joinConference(options) convenience function which creates a connection and then joins a conference. This way we could get everything we need there and piecemeal it to either the connection or the conference.

I like this approach better. A single call to JitsiMeetJS.joinConference(options) should create the connection and the conference and join the room automatically for those consumers of the library who are looking for a high-level integration.

I have few other ideas around device selection and such so that the app doesn't have to create/add/replace tracks at the conference level. That should all be handled by the library itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants