Fix RTT when SSRC rewriting is enabled. #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, this calls the notifier after the RTCP packet has passed the preProcessor where SSRC rewriting may change the packet. The callback is also moved from the receiver pipeline thread (calling into Conference.sendOut -> Endpoint.send) to the sender pipeline thread. The only code which uses this callback is EndpointConnectionStats, which saves sent SRs to calculate RTT. This commit fixes the RTT calculation when SSRC rewriting is used.
JonathanLennox
previously approved these changes
Oct 23, 2024
JonathanLennox
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by Philldomd here https://community.jitsi.org/t/version-9646-changes-websocket-removed-and-with-that-rtt-and-jitter-became-0-on-metrics/134871/8