Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(dcsctp): Allow unlimited sctp retransmissions with dcsctp. #2180

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

JonathanLennox
Copy link
Member

@JonathanLennox JonathanLennox commented Jun 17, 2024

Don't consider streams reset a "Surprising" SCTP callback.

Don't considerstreams reset a "Suprising" SCTP callback.
transport.logger.info("Surprising SCTP callback: outgoing streams ${outgoingStreams.joinToString()} reset")
// This is normal following a call to close(), which is a hard-close (as opposed to shutdown() which is
// soft-close)
transport.logger.info("Outgoing streams ${outgoingStreams.joinToString()} reset")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this useful at info?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sctp info logs are probably a bit chatty at this point, but that can be revisited later

@JonathanLennox JonathanLennox merged commit af2ff24 into jitsi:master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants