Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix routing of audio and stats when routeLoudestOnly is disabled #2055

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Sep 27, 2023

  • fix: Don't drop audio when routeLoudestOnly is disabled in config.
  • fix: Do not drop stats when routeLoudestOnly is disabled.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2055 (7843200) into master (f5f3991) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2055      +/-   ##
============================================
- Coverage     42.53%   42.49%   -0.05%     
+ Complexity     1681     1678       -3     
============================================
  Files           325      325              
  Lines         17145    17146       +1     
  Branches       2253     2253              
============================================
- Hits           7293     7286       -7     
- Misses         9135     9151      +16     
+ Partials        717      709       -8     
Files Coverage Δ
...rc/main/java/org/jitsi/videobridge/Conference.java 28.95% <33.33%> (-1.19%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f3991...7843200. Read the comment docs.

@bgrozev bgrozev merged commit ea56278 into jitsi:master Sep 27, 2023
2 of 4 checks passed
@bgrozev bgrozev deleted the fix-loudest-routing branch May 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants